zcash_client_sqlite: Fix bugs & reduce complexity in scan progress computation. #1562
+266
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scan progress computation, `recover_until_height` was incorrectly being treated as an inclusive end, meaning that it was possible for a block's notes to be counted both within the recovery range and within the scanning range.
str4d
reviewed
Oct 8, 2024
nuttycom
force-pushed
the
fix/scan_progress
branch
from
ebd1d6d
to
8eb96bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
- Coverage 61.62% 61.60% -0.02%
==========================================
Files 148 148
Lines 18825 18816 -9
==========================================
- Hits 11601 11592 -9
Misses 7224 7224 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
fix/scan_progress
branch
from
8eb96bb
to
4cef30d
Compare
We now compute the fallback tree size at the birthday height and the recover-until height separately in order to avoid the mixing of concerns.
nuttycom
force-pushed
the
fix/scan_progress
branch
from
4cef30d
to
ea89ec1
Compare
nuttycom
force-pushed
the
fix/scan_progress
branch
from
ce980a8
to
d89c09e
Compare
nuttycom
force-pushed
the
fix/scan_progress
branch
from
d89c09e
to
2cba3ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.